fix some problems #3
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the API interface for the DexHand021S class by simplifying the clear_error method to no longer require a finger_id parameter, fixing the get_error_code method to return a value, and correcting the return type for get_firmware_version. The example code is updated accordingly to use the simplified API.
Changes:
- Simplified
clear_errorto only requiredevice_idparameter - Fixed
get_error_codeto return the error code value - Updated
get_firmware_version_021sreturn type fromc_ubytetoc_uint16
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/DX021S_example.py | Updated example to use simplified clear_error API and changed adapter type |
| dexhand/dexhand.py | Modified method signatures and ctypes declarations to match updated SDK |
| cpp/sdk | Updated subproject commit reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| def get_error_code(self, device_id, finger_id): | ||
| LibDexHand.get_error_code_021s(self.instance, finger_id, device_id) | ||
| return LibDexHand.get_error_code_021s(self.instance, finger_id, device_id) |
There was a problem hiding this comment.
The parameter order in the C library call (finger_id, device_id) is inconsistent with other methods in this class, which follow the pattern (device_id, finger_id). This inconsistency could lead to incorrect API usage. Consider verifying the correct parameter order with the underlying C library and updating either this call or the argtypes declaration on line 71 to maintain consistency.
1 participant
update clearError and getErrorCode then fix setDeviceId